Code Smell 03 - Functions Are Too Long
Humans get bored beyond line 10.
Problems
- Low Cohesion
- High coupling
- Difficult to read
Solutions
1) Refactor
2) Create small objects dealing with some of the tasks. Unit test them.
3) Compose methods
Examples
- Libraries
Sample Code
Wrong
Right
Detection
All linters can measure and warn when methods are larger than a predefined threshold.
Relations
Also Known as
- Long Method
More info
Tags
- Complexity
Conclusion
Extract long method into smaller pieces. Break complex algorithms in parts. You can also unit test these parts.
Credits
Photo by Hari Panicker on Unsplash
Programs are meant to be read by humans and only incidentally for computers to execute.
Donald Knuth
This article is part of the CodeSmell Series.
No Comments Yet