# Code Smell 152 - Logical Comment

> TL;DR: Don't change code semantics to skip code.

# Problems

- Readability 

- Non-Intention Revealing

# Solutions

1. If you need a temporary hack, make it explicit

2. Rely on your source control system

# Context

Changing code with a temporary hack is a very bad developer practice.

We might *forget* some temporary solutions and leave them forever.

# Sample Code

## Wrong

[Gist Url]: # (https://gist.github.com/mcsee/a07a71db83f2c65adefffd736e77ee91)
```javascript
if (cart.items() > 11 && user.isRetail())  { 
  doStuff();
}
doMore();
// Production code

// the false acts to temporary skip the if condition
if (false && cart.items() > 11 && user.isRetail())  { 
  doStuff();
}
doMore();

if (true || cart.items() > 11 && user.isRetail())  {
// Same hack to force the condition
```

## Right

[Gist Url]: # (https://gist.github.com/mcsee/174010435acb2c12f45124f2a085fa51)
```javascript
if (cart.items() > 11 && user.isRetail())  { 
  doStuff();
}
doMore();
// Production code

// Either if we need to force or skip the condition
// we can do it with a covering test forcing
// real world scenario and not the code

testLargeCartItems() {}

testUserIsRetail() {}
```

# Detection

[X] Semi-Automatic 

Some linters might warn us of strange behavior.

# Tags

- Comments

# Conclusion

Separation of concerns is extremely important in our profession.

Business logic and hacks should always be apart.

# Relations

%[https://maximilianocontieri.com/code-smell-151-commented-code]

# Credits

Photo by [Belinda Fewings](https://unsplash.com/@bel2000a) on [Unsplash](https://unsplash.com/s/photos/road-closed)  

Thanks, @[Ramiro Rela](@racter) for this tip

* * *

> You might not think that programmers are artists, but programming is an extremely creative profession. It's logic-based creativity.

_John Romero_
 
%[https://maximilianocontieri.com/software-engineering-great-quotes]

* * *

This article is part of the CodeSmell Series.

%[https://maximilianocontieri.com/how-to-find-the-stinky-parts-of-your-code]