Follow

Follow
Code Smell 162 - Too Many Parentheses

Photo by Nick Fewings on Unsplash

Code Smell 162 - Too Many Parentheses

Parentheses are free of charge. Aren't they?

Maxi Contieri⭐⭐⭐'s photo
Maxi Contieri⭐⭐⭐
·Sep 10, 2022·

1 min read

Play this article

Table of contents

  • Code Smell 162 - Too Many Parentheses
  • Problems
  • Solutions
  • Context
  • Sample Code
  • Detection
  • Exceptions
  • Tags
  • Relations
  • Conclusion
  • Disclaimer
  • Credits

Code Smell 162 - Too Many Parentheses

TL;DR: Use as few parentheses as possible.

Problems

  • Readability

  • Syntactic complexity

Solutions

  1. Remove all not necessary parentheses

Context

We read code from left to right (at least in western culture).

Parentheses often break this flow, adding cognitive complexity

Sample Code

Wrong


schwarzschild = ((((2 * GRAVITATION_CONSTANT)) * mass) / ((LIGHT_SPEED ** 2)))

Right


schwarzschild = (2 * GRAVITATION_CONSTANT * mass) / (LIGHT_SPEED ** 2)

Detection

[X] Automatic

This is a fully automated code smell.

It is based on syntax trees.

Many tools detect it.

Exceptions

On some complex formulas, we can add extra parenthesis for terms readability.

Tags

  • Readability

  • Bloaters

Relations

Conclusion

We write code once and read it too many times.

Readability is king.

Disclaimer

Code Smells are just my opinion.

Credits

Photo by Nick Fewings on Unsplash


If someone claims to have the perfect programming language, he is either a fool or a salesman or both.

Bjarne Stroustrup


This article is part of the CodeSmell Series.

 
Share this