Code Smell 165 - Empty Exception Blocks

Photo by James Best on Unsplash

Code Smell 165 - Empty Exception Blocks

Maxi Contieri
·Sep 24, 2022·

2 min read

Subscribe to my newsletter and never miss my upcoming articles

Play this article

Table of contents

  • Problems
  • Solutions
  • Context
  • Sample Code
  • Detection
  • Exceptions
  • Tags
  • Conclusion
  • Relations
  • More Info
  • Disclaimer
  • Credits

On Error resume next was the first thing I learned in my first job

TL;DR: Don't avoid exceptions. Handle Them.

Problems

Solutions

  1. Catch the exception and deal with it explicitly

Context

On early programming days, we privileged the systems running before error handling.

We have evolved.

Sample Code

Wrong

# bad
import logging

def send_email(): 
  print("Sending email") 
  raise ConnectionError("Oops")

try:
  send_email() 
except: 
  # AVOID THIS
pass

Right

import logging

logger logging.getLogger(__name___)
try:
  send_email()
except ConnectionError as exc:
  logger.error(f"Cannot send email {exc}")

Detection

[X] Automatic

Many linters warn us on empty exception blocks

Exceptions

If we need to skip and ignore the exception, we should document it explicitly.

Tags

  • Exceptions

Conclusion

Prepare to deal with the errors.

Even if you decide to do nothing, you should be explicit with this decision.

Relations

More Info

On Error Resume Next Package

Disclaimer

Code Smells are just my opinion.

Credits

Photo by James Best on Unsplash

Thank you Jan Giacomelli


Optimization hinders evolution. Everything should be built top-down, except the first time. Simplicity does not precede complexity, but follows it.

Alan Perlis


This article is part of the CodeSmell Series.

 
Share this