Code Smell 51 - Double Negatives

Subscribe to my newsletter and never miss my upcoming articles

Not operator is our friend. Not not operator is not our friend.

Problems

  • Readability

Solutions

  1. Name your variables, methods and classes with positive names.

Sample Code

Wrong

Detection

This is a semantic smell. We need to detect it on code reviews.

We can tell linters to check for Regular Expressions like !not or !isNot etc as a warning.

Tags

  • Readability

Conclusion

Double negation is a very basic rule we learn as junior developers.

There are lots of production systems filled with this smell.

We need to trust our test coverage and make safe renames and other refactors.

Relations

More info

Credits

Photo by Daniel Herron on Unsplash


It’s harder to read code than to write it.

Joel Spolsky



This article is part of the CodeSmell Series.

Comments (1)

Chris Bongers's photo

Interesting point!

Agree, would be cool how to setup a linter for this