Code Smell 53 - Explicit Iteration

Subscribe to my newsletter and never miss my upcoming articles

We learned loops back in school. But enumerators and iterators are the next generation.

Problems

  • Encapsulation

  • Declarativeness

Solutions

  1. Favor foreach() or high order iterators

  2. You will be able to use yield(), caches, proxies, lazy loading and much more when you hide your implementation details.

Sample Code

Wrong

Detection

Linters can find this smell using regex.

There might be false positives. See exceptions below.

Exceptions

If the problem domain needs the elements to be bijected to natural numbers like indices the first solution is adequate.

Remember all time to find real world analogies.

Tags

  • Declarative

Conclusion

This kind of smell do not ring the bell to many developers because they think this is a subtlety.

Clean code is full of this few declarative things that can make a difference.

Relations

More info

Credits

Photo by Elena Mozhvilo on Unsplash


If you get tired of writing for loops, take a break and continue later.

David Walker



Original twitter thread by Matt Moll


This article is part of the CodeSmell Series.

Comments (3)

Chris Bongers's photo

Nice one!

I do wonder some times I favor a basic for i++ loop since forEach is not 100% browser supported.

What's your take on that?

Maxi Contieri's photo

An implicit prerequisite is that the code must work.

So a beautiful and declarative not working foreach is not a choice having a working explicit i++

The code must always work. If you have evidence some browsers does not support the declarative one i am ok with the old way.

Shame on browser compatibility

Chris Bongers's photo

Maxi Contieri That makes sense, thanks for explaining

And yes, shame on browser compatibility!