Code Smell 58 - Yo-yo Problem

Subscribe to my newsletter and never miss my upcoming articles

Searching for a concrete method implementation? Go back and forth, up and down.


  • Deep Hierarchies

  • Subclassification for Code Reuse

  • Readability

  • Low Cohesion

  • High Coupling


  1. Favor composition over inheritance.

  2. Refactor deep hierarchies.

Sample Code



Any linter can check for suspects against a max depth threshold.


  • Hierarchy


Many novice programmers reuse code through hierarchies. This brings high coupled and low cohesive hierarchies.

Johnson and Foote established in their paper this was actually a good design recipe back in 1988. We have learned a lot from there.

We must refactor and flatten those classes.


More info


Hierarchies should be deep by Johnson and Foote

An error arises from treating object variables (instance variables) as if they were data attributes and then creating your hierarchy based on shared attributes. Always create hierarchies based on shared behaviors, side.

David West

This article is part of the CodeSmell Series.

No Comments Yet