<p><em>Methods should be interchangeable if they do the same.</em></p>
<h1 id="problems">Problems</h1>
<ul>
<li><p>Missed Polymorphism</p>
</li>
<li><p>Coupling</p>
</li>
<li><p>IFs / Type check Polluting.</p>
</li>
<li><p>Names coupled to types.</p>
</li>
</ul>
<div class="embed-wrapper"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a class="embed-card" href="https://maximilianocontieri.com/how-to-get-rid-of-annoying-ifs-forever">https://maximilianocontieri.com/how-to-get-rid-of-annoying-ifs-forever</a></div>
<h1 id="solutions">Solutions</h1>
<ol>
<li><p>Rename methods after what they do.</p>
</li>
<li><p>Favor polymorphism.</p>
</li>
</ol>
<h1 id="sample-code">Sample Code</h1>
<h2 id="wrong">Wrong</h2>
<div class="gist-block embed-wrapper" data-gist-show-loading="false" data-id="17ccba69a9bcb7fbe2e8ee15e0487585"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a href="https://gist.github.com/mcsee/17ccba69a9bcb7fbe2e8ee15e0487585" class="embed-card">https://gist.github.com/mcsee/17ccba69a9bcb7fbe2e8ee15e0487585</a></div><h2 id="right">Right</h2>
<div class="gist-block embed-wrapper" data-gist-show-loading="false" data-id="ba7cb02ed4cf4c8ae6d0bf4aae3d7cb2"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a href="https://gist.github.com/mcsee/ba7cb02ed4cf4c8ae6d0bf4aae3d7cb2" class="embed-card">https://gist.github.com/mcsee/ba7cb02ed4cf4c8ae6d0bf4aae3d7cb2</a></div><h1 id="detection">Detection</h1>
<p>This is a semantic mistake. We could add a warning for <em>similar</em> method names on Polymorphic classes.</p>
<h1 id="tags">Tags</h1>
<ul>
<li>Polymorphic</li>
</ul>
<h1 id="conclusion">Conclusion</h1>
<p>Naming is very important. We need to name after concepts and not after accidental types.</p>
<h1 id="relations">Relations</h1>
<div class="embed-wrapper"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a class="embed-card" href="https://maximilianocontieri.com/code-smell-36-switchcaseelseifelseif-statements">https://maximilianocontieri.com/code-smell-36-switchcaseelseifelseif-statements</a></div>
<h1 id="more-info">More info</h1>
<div class="embed-wrapper"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a class="embed-card" href="https://maximilianocontieri.com/what-exactly-is-a-name-part-ii-rehab">https://maximilianocontieri.com/what-exactly-is-a-name-part-ii-rehab</a></div>
<hr />
<blockquote>
<p>If you have three pet dogs, give them names. If you have 10,000 head of cattle, don't bother. Nowadays, the idea of giving a name to every file on your computer is ridiculous.</p>
</blockquote>
<p><em>David Gelernter</em></p>
<hr />
<div class="embed-wrapper"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a class="embed-card" href="https://mcsee.hashnode.dev/software-engineering-great-quotes">https://mcsee.hashnode.dev/software-engineering-great-quotes</a></div>
<hr />
<p>This article is part of the CodeSmell Series.</p>
<div class="embed-wrapper"><div class="embed-loading"><div class="loadingRow"></div><div class="loadingRow"></div></div><a class="embed-card" href="https://mcsee.hashnode.dev/how-to-find-the-stinky-parts-of-your-code">https://mcsee.hashnode.dev/how-to-find-the-stinky-parts-of-your-code</a></div>


*Methods should be interchangeable if they do the same.*

# Problems

- Missed Polymorphism

- Coupling

- IFs / Type check Polluting.

- Names coupled to types.

%[https://maximilianocontieri.com/how-to-get-rid-of-annoying-ifs-forever]

# Solutions

1. Rename methods after what they do.

2. Favor polymorphism.

# Sample Code

## Wrong

%[https://gist.github.com/mcsee/17ccba69a9bcb7fbe2e8ee15e0487585]

## Right

%[https://gist.github.com/mcsee/ba7cb02ed4cf4c8ae6d0bf4aae3d7cb2]

# Detection

This is a semantic mistake. We could add a warning for *similar* method names on Polymorphic classes.

# Tags

- Polymorphic

# Conclusion

Naming is very important. We need to name after concepts and not after accidental types.

# Relations

%[https://maximilianocontieri.com/code-smell-36-switchcaseelseifelseif-statements]

# More info

%[https://maximilianocontieri.com/what-exactly-is-a-name-part-ii-rehab]


* * *

> If you have three pet dogs, give them names. If you have 10,000 head of cattle, don't bother. Nowadays, the idea of giving a name to every file on your computer is ridiculous.

_David Gelernter_
 
* * *
 
%[https://mcsee.hashnode.dev/software-engineering-great-quotes]

* * *

This article is part of the CodeSmell Series.

%[https://mcsee.hashnode.dev/how-to-find-the-stinky-parts-of-your-code]

Code Smell 45 - Not Polymorphic

Learn something new every day. 💻
CS software engineer
👷working
👨🏽‍🏫teaching
✍🏾writing
🎨Software design
🏢SOLID
🌉TDD
👴Legacy 
Write me at info(at)maximilianocontieri.com


I am Maximiliano Contieri
I've been working as a software engineer and teaching for about 25 years.
I write about software design, refactoring, test driven development, clean code and code smells.