TL;DR: Replace static functions with object interactions.

Problems Addressed

High coupling due to global access
Poor testability
Overloaded protocols in classes
Decreased cohesion

https://maximilianocontieri.com/code-smell-18-static-functions

https://maximilianocontieri.com/code-smell-17-global-functions

https://maximilianocontieri.com/code-smell-22-helpers

Steps

Identify static methods used in your code.
Replace static methods with instance methods.
Pass dependencies explicitly through constructors or method parameters.
Refactor clients to interact with objects instead of static functions.

Sample Code

Before

class CharacterUtils {
    static createOrpheus() {
        return { name: "Orpheus", role: "Musician" };
    }

    static createEurydice() {
        return { name: "Eurydice", role: "Wanderer" };
    }

    static lookBack(character) {
      if (character.name === "Orpheus") {
        return "Orpheus looks back and loses Eurydice.";
    } else if (character.name === "Eurydice") {
        return "Eurydice follows Orpheus in silence.";
    }
       return "Unknown character.";
  }
}

const orpheus = CharacterUtils.createOrpheus();
const eurydice = CharacterUtils.createEurydice();

After

// 1. Identify static methods used in your code.
// 2. Replace static methods with instance methods.
// 3. Pass dependencies explicitly through
// constructors or method parameters.

class Character {
    constructor(name, role, lookBackBehavior) {
        this.name = name;
        this.role = role;
        this.lookBackBehavior = lookBackBehavior;
    }

    lookBack() {
        return this.lookBackBehavior(this);
    }
}

// 4. Refactor clients to interact with objects 
// instead of static functions.
const orpheusLookBack = (character) =>
    "Orpheus looks back and loses Eurydice.";
const eurydiceLookBack = (character) =>
    "Eurydice follows Orpheus in silence.";

const orpheus = new Character("Orpheus", "Musician", orpheusLookBack);
const eurydice = new Character("Eurydice", "Wanderer", eurydiceLookBack);

Type

[X] Semi-Automatic

You can make several step-by-step replacements.

Safety

This refactoring is generally safe, but you should test your changes thoroughly.

Ensure no other parts of your code depend on the static methods you replace.

Why is the Code Better?

Your code is easier to test because you can replace dependencies during testing.

Objects encapsulate behavior, improving cohesion and reducing protocol overloading.

You remove hidden global dependencies, making the code clearer and easier to understand.

Refactor with AI

Without Proper Instructions	With Specific Instructions
ChatGPT	ChatGPT
Claude	Claude
Perplexity	Perplexity
Copilot	Copilot
Gemini	Gemini

Credits

Image by Menno van der Krift from Pixabay

This article is part of the Refactoring Series.

https://maximilianocontieri.com/how-to-improve-your-code-with-easy-refactorings

Refactoring 020 - Transform Static Functions

Comments

Refactorings

Refactoring 019 - Reify Email Addresses

More from this blog

AI Coding Tip 030 - Script Your Skills, Not Your Prompts

AI Coding Tip 029 - Stop Using One Model for Everything

AI Coding Tip 028 - Build a Company Brain

AI Coding Tip 027 - Force Code Standards

AI Coding Tip 026 - Assign a Persona to Every Skill Definition

Problems Addressed

Steps

Sample Code

Before

After

Type

Safety

Why is the Code Better?

Refactor with AI

Tags

See also

Credits

Command Palette

Comments

Refactorings

Refactoring 019 - Reify Email Addresses

More from this blog

Problems Addressed

Related Code Smells

Steps

Sample Code

Before

After

Type

Safety

Why is the Code Better?

Refactor with AI

Tags

Related Refactorings

See also

Credits